[lworld] RFR: 8304168: Modify CDS tests to disable -XX:-EnableValhalla with --enable-preview

Mandy Chung mchung at openjdk.org
Tue Mar 14 19:10:28 UTC 2023


On Tue, 14 Mar 2023 18:50:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> When --enable-preview is true, the patching of some java.base classes as value classes disables CDS. 
> Subsequently the CDS tests fail.
> 
> For a CDS and a JDI test, disable Valhalla when --enable-preview is set so java.base is not patched with value classes.

Is this just a temporary fix?   We would need debugging to work with `--enable-preview`.   For CDS, is it possible to have an alternative shared archive with the value classes and special case for `--enable-preview`?

-------------

PR: https://git.openjdk.org/valhalla/pull/832



More information about the valhalla-dev mailing list