[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v3]

[Xiaohong Gong]

On Wed, 29 Mar 2023 08:47:50 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Extend ci model to capture synthetic multi-fields, these are used for scalarization if target does not support load/store bundle size.
>
> src/hotspot/share/opto/inlinetypenode.hpp line 117:
> 
>> 115:   bool          is_multifield(uint index) const;
>> 116:   bool          is_multifield_base(uint index) const;
>> 117:   int           secondary_field_count(uint index) const;
> 
> Rename to `secondary_fields_count` ? Or is it possible getting the count from the field type like `type->bundle_size()`, so that this method can be removed?

BTW, methods like `is_multifield, is_multifield_base` can be removed. `secondary_fields_count() > 1` can be used as a replacement to `is_multifield_base()`, right?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1152696987