[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v11]

Jatin Bhateja jbhateja at openjdk.org
Tue May 2 05:05:42 UTC 2023


On Sun, 23 Apr 2023 08:03:00 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Few fixes for failing vector API regression.
>
> src/hotspot/share/opto/vector.cpp line 391:
> 
>> 389:     ciField* mutifield = payload_klass->declared_nonstatic_field_at(0);
>> 390:     offset += mutifield->offset();
>> 391:   }
> 
> If the `payload_field` is not flattened, I'm afraid the payload value should be buffered like the original array instance?

Payloads are primitive type objects of VectorPayloadMF* classes, by default should be flattened in the containing object i.e. container object size will take into account flattened fields sizes, but flattening happens under the influence of InlineFieldMaxFlatSize runtime flag, above code handles non-flattened case.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1182083498



More information about the valhalla-dev mailing list