[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v14]

[Xiaohong Gong]

On Mon, 20 Mar 2023 07:21:00 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolutions.
>
> src/hotspot/share/opto/vectornode.cpp line 861:
> 
>> 859:     return n->in(1)->bottom_type() == TypeF::ONE;
>> 860:   case Op_ReplicateD:
>> 861:     return n->in(1)->bottom_type() == TypeD::ONE;
> 
> `is_all_ones_vector` here means all bits are `1` (i.e. `-1` for integer types). So `TypeF::ONE` is not the right value here?

Missed this comment?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1189291070