[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v14]

[Jatin Bhateja]

On Wed, 10 May 2023 11:07:06 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolutions.
>
> src/hotspot/share/opto/parse1.cpp line 924:
> 
>> 922:     kit.sync_jvms();
>> 923:     Node* res = kit.argument(0);
>> 924:     if (res->isa_InlineType() && VectorSupport::skip_value_scalarization(res->as_InlineType()->inline_klass()->get_InlineKlass())) {
> 
> I think in general multi-field fields should be scalarised differently from normal fields, since they represent an array and ideally should be packed together on the stack instead of passing separately. As a result, for now it may be better to reject scalarisation of types with multi-fields altogether.

Agree. We will eventually need to extend new return calling convention to support vectors.
https://github.com/openjdk/valhalla/pull/833#discussion_r1189730320

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1189749759