[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v16]
Jatin Bhateja
jbhateja at openjdk.org
Mon May 15 02:12:16 UTC 2023
On Fri, 12 May 2023 18:33:23 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review cleanups.
>
> src/hotspot/share/opto/graphKit.cpp line 1070:
>
>> 1068: bool ignored_will_link;
>> 1069: ciField* field = method()->get_field_at_bci(bci(), ignored_will_link);
>> 1070: int size = field->is_multifield_base() ?
>
> Encapsulate size computation for mulitfields in `ciField`?
Decision to scalarize a multi-field is delegated to compiler, ci* model is sacrosanct. So a size query over ciMultiField (base) will always return the entire bundle size, we have to to a special handling on compiler side. I have factored this into a static routine.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1193266168
More information about the valhalla-dev
mailing list