[lworld+vector] RFR: 8307715: Integrate VectorMask with value/primitive classes [v2]

Xiaohong Gong xgong at openjdk.org
Fri May 19 01:16:11 UTC 2023


On Thu, 18 May 2023 10:31:20 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> > > > I am seeing some new regression failures with -XX:TieredStopAtLevel=3 and -XX:-TieredCompilation. Can you kindly check. Relevant test : Float256VectorTest.java.
> > > 
> > > 
> > > Sure, I will run this test. Thanks!
> > 
> > 
> > There are some failures that are related to the `larval` state check, and deoptimization issue for a multifield, which I think is not related this patch. And I have created a local fix to the multifield deoptimization issue and will push it in future. Besides, did you see any other known failures before? Thanks!
> 
> With -XX:-TieredCompilation I see following crash right at the start for the regression run, looks like we need to handle [mask type value during rematerialization.](https://github.com/openjdk/valhalla/blob/lworld%2Bvector/src/hotspot/share/runtime/deoptimization.cpp#L1144)
> 
> [hs_err_pid718455.log](https://github.com/openjdk/valhalla/files/11506850/hs_err_pid718455.log)

Right! I missed the deoptimization part when I was doing the VectorMask integration. In my VectorShuffle changes, I'v changed all these relative code. Thanks!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/845#issuecomment-1553875322



More information about the valhalla-dev mailing list