[lworld+vector] RFR: 8307715: Integrate VectorMask/Shuffle with value/primitive classes [v5]

[Xiaohong Gong]

On Wed, 24 May 2023 06:56:23 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix jtreg failures
>
> src/hotspot/share/opto/library_call.cpp line 2323:
> 
>> 2321:       if (alloc != NULL) {
>> 2322:         assert(alloc->_larval, "InlineType instance must be in _larval state for unsafe put operation.\n");
>> 2323:       }
> 
> Larval bit check is needed to preserve the semantics of value objects which can be mutated only if its _larval bit is set,  allocation expansion explicitly generates IR to set this information in the mark word.  We should add a FIXME over if condition.

Yes, the issue here is the `oop` of the `InlineTypeNode` is not always the `AllocateNode`. We may need to add an utility method to check the oop's larval state. I will add a FIXME for further fixing.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/845#discussion_r1204922284