[lworld+vector] RFR: 8307715: Integrate VectorMask/Shuffle with value/primitive classes [v6]

[Xiaohong Gong]

On Mon, 29 May 2023 06:59:48 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/hotspot/share/opto/inlinetypenode.cpp line 154:
> 
>> 152: // Merges 'this' with 'other' by updating the input PhiNodes added by 'clone_with_phis'
>> 153: InlineTypeNode* InlineTypeNode::merge_with(PhaseGVN* gvn, const InlineTypeNode* other, int pnum, bool transform) {
>> 154:   assert(this->Opcode() == other->Opcode(), "");
> 
> May I know the reason to remove this assertion? it ensures we never merge an InlineTypeNode with VectorBoxNode.

This assertion fails when I run jtreg tests like Float128VectorTests.java at the start of running the tests. I didn't figure out what was wrong. Maybe we can add it back and look at this issue.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/845#discussion_r1208987786