[lworld+vector] RFR: 8319972: [lworld+vector] Enable intrinsification of Unsafe.finishPrivateBuffer.

Xiaohong Gong xgong at openjdk.org
Thu Nov 16 07:33:53 UTC 2023


On Thu, 16 Nov 2023 07:20:34 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/share/opto/macro.cpp line 964:
>> 
>>> 962:   if (alloc->_larval) {
>>> 963:     return false;
>>> 964:   }
>> 
>> Does it need to also add such checks in `InlineTypeNode::make_scalar_in_safepoints` ?
>
> With new behavior, a value object in larval state is already allocated over heap and should not be scalarized to InlineTypeNode.

Yes, that's true. So can we still generate the `InlineTypeNode` with the larval state buffer as its oops like before? And we can avoid its scalarization by just checking the larval state.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/952#discussion_r1395260684



More information about the valhalla-dev mailing list