[lworld] RFR: 8320437: [lworld] Adding internal null-restricted storage API points [v2]

Tobias Hartmann thartmann at openjdk.org
Tue Nov 21 15:38:42 UTC 2023


On Tue, 21 Nov 2023 14:58:55 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Adding internal null-restricted storage API points
>
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix wrong class type in test

test/hotspot/jtreg/runtime/valhalla/inlinetypes/ClassInitializationFailuresTest.java line 152:

> 150:         // Asserts.assertNotNull(e, "Error should have been thrown");
> 151:         // Asserts.assertTrue(e.getClass() == NoClassDefFoundError.class, "Must be a NoClassDefFoundError");
> 152:         // Asserts.assertTrue(e.getCause().getClass() == ExceptionInInitializerError.class, "Must be an ExceptionInInitializerError");

I would suggest to use `/*` `*/` for uncommenting because it does not affect git blame history of the other lines.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/947#discussion_r1400786616



More information about the valhalla-dev mailing list