[lworld+vector] RFR: 8319972: [lworld+vector] Enable intrinsification of Unsafe.finishPrivateBuffer. [v3]

[Xiaohong Gong]

On Wed, 15 Nov 2023 04:10:07 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Some more fixes and cleanups
>>  - Merge branch 'lworld+vector' of http://github.com/openjdk/valhalla into JDK-8319972
>>  - Review comments resolutions
>>  - Regression fixes
>>  - 8319972: [lworld+vector] Enable intrinsification of Unsafe.finishPrivateBuffer.
>
> src/hotspot/share/opto/inlinetypenode.cpp line 1024:
> 
>> 1022: 
>> 1023:   store(kit, alloc_oop, alloc_oop, vk);
>> 1024:   return alloc_oop;
> 
> Why not setting the oop to allocated buffer and return the `InlineTypeNode` ? We may have optimizations for Unsafe access for `InlineTypeNode` input.

Any feedback on this please?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/952#discussion_r1401571532