[lworld+vector] RFR: 8319972: [lworld+vector] Enable intrinsification of Unsafe.finishPrivateBuffer. [v3]

[Jatin Bhateja]

On Wed, 22 Nov 2023 06:39:52 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Some more fixes and cleanups
>>  - Merge branch 'lworld+vector' of http://github.com/openjdk/valhalla into JDK-8319972
>>  - Review comments resolutions
>>  - Regression fixes
>>  - 8319972: [lworld+vector] Enable intrinsification of Unsafe.finishPrivateBuffer.
>
> src/hotspot/share/opto/parse1.cpp line 1782:
> 
>> 1780:           // Scalarize null in src block to be able to merge it with inline type in target block
>> 1781:           assert(gvn().type(n)->is_zero_type(), "Should have been scalarized");
>> 1782:           map()->set_req(j, InlineTypeNode::make_null(gvn(), t->inline_klass()));
> 
> Did you check why this assertion is hit for larval state buffer? I mean is it possible that the inline type buffer in larval state should not go to this path.

Since make_larval now generates the oop hence will hit upon this control path, we no longer create InlineTypeNode for value objects in larval state.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/952#discussion_r1401632358