[lworld] RFR: 8320437: [lworld] Adding internal null-restricted storage API points [v3]

Tobias Hartmann thartmann at openjdk.org
Fri Nov 24 11:10:34 UTC 2023


On Tue, 21 Nov 2023 19:00:12 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Adding internal null-restricted storage API points
>
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Field inheritance check should be limited to instance fields

test/hotspot/jtreg/runtime/valhalla/inlinetypes/ClassInitializationFailuresTest.java line 134:

> 132:         Asserts.assertTrue(e.getClass() == NoClassDefFoundError.class, "Must be a NoClassDefFoundError");
> 133:         Asserts.assertTrue(e.getCause().getClass() == ExceptionInInitializerError.class, "Must be an ExceptionInInitializerError");
> 134:         // Transition model (annotations and array factory) doesn't permit multi-dimentional arrays tests

Shouldn't we support multi-dimensional arrays as well? Or are there any blockers?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/947#discussion_r1404233890



More information about the valhalla-dev mailing list