[lworld+vector] RFR: 8311675: [lworld+vector] Max Species support.

Xiaohong Gong xgong at openjdk.org
Sun Oct 8 02:13:32 UTC 2023


On Thu, 28 Sep 2023 18:02:04 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

> - Patch adds MaxSpecies support for all types of vectors.
> - New factory methods and VectorPayload classes for various kinds of vector, shuffle and mask payloads.
> - Disable CDS archiving of VectorPayload classes.
> - Summary of high level flow :-
>   1/ Max species payloads encapsulate @multifield annotated field accepting -1 value as bundle size parameter.
>   2/ For Vector payload bundle size is determined using maximum vector size supported by the target. 
>   3/ For Shuffles and Masks payloads multifield bundle size is a function of maximum vector size and vector lane size.
>   4/ Based on the dynamic bundle size parser creates a separate FieldInfo structure for each base and synthetic multifield and rest of the flow remains the same. 
> 
> Kindly review and share your feedback.
> 
> Best Regards,
> Jatin

src/hotspot/share/ci/ciObjectFactory.cpp line 55:

> 53: #include "memory/universe.hpp"
> 54: #include "oops/oop.inline.hpp"
> 55: #include "prims/vectorSupport.hpp"

Not used and revert it?

src/hotspot/share/prims/vectorSupport.hpp line 143:

> 141:   static int  max_vector_size(BasicType bt);
> 142:   static int  get_max_multifield_count(const Symbol* payload_name);
> 143:   static bool is_vector_payload(const Symbol* metadata);

`is_vector_payload` is not used and can be removed?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/931#discussion_r1349609459
PR Review Comment: https://git.openjdk.org/valhalla/pull/931#discussion_r1349609426



More information about the valhalla-dev mailing list