[lworld] RFR: 8317658: [lworld] TemplateTable::withfield() does not correctly load the ResolvedFieldEntry

Frederic Parain fparain at openjdk.org
Mon Oct 9 16:10:26 UTC 2023


On Mon, 9 Oct 2023 09:03:17 GMT, David Simms <dsimms at openjdk.org> wrote:

> Ensure ResolvedFieldEntry is correctly loaded
> 
> More testing might well be in order, but we are more than likely to remove `withfield` . To make up for the testing, using `assert(entry->is_valid())` upon passing to the interpreter runtime is useful for avoiding bugs in future changes to the hand-rolled assembler, that can be error prone when holding a lot of registers (e.g. `putfield`).

Marked as reviewed by fparain (Committer).

-------------

PR Review: https://git.openjdk.org/valhalla/pull/936#pullrequestreview-1664878676



More information about the valhalla-dev mailing list