[lworld+vector] RFR: 8311675: [lworld+vector] Max Species support. [v3]

Jatin Bhateja jbhateja at openjdk.org
Mon Oct 16 06:34:26 UTC 2023


On Mon, 16 Oct 2023 01:09:52 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolutions.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractMask.java line 143:
> 
>> 141:                 species.maskType(), species.elementType(), vspecies().laneCount,
>> 142:                 this, species,
>> 143:                 (m, s) -> VectorMask.fromLong(s, m.toLong()).check(s));
> 
> Any issues with the original `maskFactory()` ?

We cannot typecast value object with another value type, thus directly passing payload (m.getBits()) to maskFactory will cause compilation failures.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/931#discussion_r1360171364



More information about the valhalla-dev mailing list