[lworld+vector] RFR: 8311675: [lworld+vector] Max Species support. [v4]

[Jatin Bhateja]

On Tue, 17 Oct 2023 01:08:35 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

> Generally LGTM! Just some minor code style.

Hi @XiaohongGong ,

Just to confirm do you still see the failing regressions on AARCH64 ?

> src/hotspot/cpu/x86/vm_version_x86.cpp line 3232:
> 
>> 3230:     size = (VM_Version::supports_avx512bw()) ? 64 : 32;
>> 3231:   // Use flag to limit vector size.
>> 3232:   size = MIN2(size,(int)MaxVectorSize);
> 
> Since `MaxVectorSize` is a C2 specific version, what the behavior if c2 is disabled? Do you think we need consider `#if COMPILER2` here?

We do have a dependency on C2 one way or other,  I think we should preserve the existing behaviour which will return a -1 value.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/931#issuecomment-1765532980
PR Review Comment: https://git.openjdk.org/valhalla/pull/931#discussion_r1361424845