[lworld+vector] RFR: 8311675: [lworld+vector] Max Species support. [v4]

Jatin Bhateja jbhateja at openjdk.org
Wed Oct 18 00:40:04 UTC 2023


On Tue, 17 Oct 2023 02:56:16 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

> > > > > Generally LGTM! Just some minor code style.
> > > > 
> > > > 
> > > > Hi @XiaohongGong ,
> > > > Just to confirm do you still see the failing regressions on AARCH64 ?
> > > 
> > > 
> > > Yes, `DoubeMaxVectorTests.java` still has regression like:
> > > ```
> > > test DoubleMaxVectorTests.IS_FINITEMaskedDoubleMaxVectorTests(double[cornerCaseValue(i)], mask[i % 2]): failure
> > > java.lang.AssertionError: expected [true] but found [false]
> > >         at org.testng.Assert.fail(Assert.java:99)
> > >         at org.testng.Assert.failNotEquals(Assert.java:1037)
> > >         at org.testng.Assert.assertEqualsImpl(Assert.java:140)
> > >         at org.testng.Assert.assertEquals(Assert.java:122)
> > >         at org.testng.Assert.assertEquals(Assert.java:819)
> > >         at org.testng.Assert.assertEquals(Assert.java:829)
> > >         at DoubleMaxVectorTests.IS_FINITEMaskedDoubleMaxVectorTests(DoubleMaxVectorTests.java:2716)
> > > ```
> > > 
> > > 
> > > All other tests pass except this one.
> > 
> > 
> > May I request to to root cause and share your observations.
> > Best Regards
> 
> Not sure whether this is the same reason with the regressions with `-XX:+DeoptimizeALot`. But we can integrate this patch first and revisit this issue together with `-XX:+DeoptimizeALot` issues.

Yes, it looks unrelated to this patch.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/931#issuecomment-1767406601



More information about the valhalla-dev mailing list