[lworld+vector] RFR: 8314980: [lworld+vector] consider scalarization conditions during ciMultiField creation. [v5]

Jatin Bhateja jbhateja at openjdk.org
Mon Sep 4 09:40:03 UTC 2023


On Mon, 4 Sep 2023 09:03:37 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Yes, correct. Per my understanding `#if COMPILER2` is a compile flag which is true if C2 is not disabled. Hence this code is just like directly `return InlineTypeNode::is_multifield_scalarized(bt, vec_length);`, right? And then it returns the same value for interpreter/c1/c2.
>
> I think what we need is adding an interface here, and implement it in different compilers, or a runtime check like https://github.com/openjdk/valhalla/blob/lworld%2Bvector/src/hotspot/share/compiler/compilerDefinitions.inline.hpp#L49. WDYT?

> Yes, correct. Per my understanding `#if COMPILER2` is a compile flag which is true if C2 is not disabled. Hence this code is just like directly `return InlineTypeNode::is_multifield_scalarized(bt, vec_length);`, right? And then it returns the same value for interpreter/c1/c2.

My bad, I completely overlooked it, you are correct.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/918#discussion_r1314692361



More information about the valhalla-dev mailing list