[lworld] RFR: 8311219: [lworld] VM option "InlineFieldMaxFlatSize" cannot work well [v2]

[Xiaohong Gong]

On Mon, 4 Sep 2023 12:37:39 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> Sorry, above fix is not correct. I forgot that it's perfectly fine for non-flat but null-free fields to be initialized with null. We then need to replace null with the default value. Let's adjust the assert instead:
> 
> ```
> -  assert(!null_free || vt->is_allocated(&gvn), "inline type should be allocated");
> +  assert(!null_free || gvn.type(oop)->maybe_null() || vt->is_allocated(&gvn), "inline type should be allocated");
> ```
> 
> I'll revisit these asserts with JDK-8284443.

Thanks for looking at this failure! Do you think it's necessary that I adjust the assertion in this PR and revisit it in future?

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/888#issuecomment-1705878464