[lworld] RFR: 8311219: [lworld] VM option "InlineFieldMaxFlatSize" cannot work well [v4]

Xiaohong Gong xgong at openjdk.org
Fri Sep 8 07:10:07 UTC 2023


On Fri, 8 Sep 2023 04:50:55 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi @jatin-bhateja @TobiHartmann , I'v added the IR tests which check the oop load number for non-flattened inline type fields. Please help to take a look whether it's fine. Thanks in advance!
>
> Thanks @XiaohongGong, LGTM!
> An alternate way could be to just check existence of InlineTypeNode in post parse IR.
> `@IR(phase = {CompilePhase.AFTER_PARSING}, counts = {IRNode.INLINE_TYPE, " > 0 "})`

I also tried to check `InlineTypeNode`, but unfortunately `InlineTypeNode` is also optimized out after parsing due to no usage in this case, which is the same with the field flattened.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/888#discussion_r1319456944



More information about the valhalla-dev mailing list