[lworld+fp16] RFR: 8308363: Initial compiler support for FP16 scalar operations. [v7]

Jatin Bhateja jbhateja at openjdk.org
Mon Sep 18 17:35:08 UTC 2023


On Tue, 12 Sep 2023 21:23:02 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

> Do we need this change now that we have special handling in the VM for Float16?

Yes, Float16 being a primitive class needs this flag during build time compilation.

> Could we do without movswl here?

This was done keeping in mind JVM semantics where byte/short are internally promoted to int type since JVM operands and local variables are 32 bit values.

> could this be called add instead of sum?

I made this change after Paul offline comments, to align it with Float.sum API.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/848#discussion_r1329071277
PR Review Comment: https://git.openjdk.org/valhalla/pull/848#discussion_r1329071225
PR Review Comment: https://git.openjdk.org/valhalla/pull/848#discussion_r1329071334



More information about the valhalla-dev mailing list