[lworld+fp16] RFR: 8308363: Initial compiler support for FP16 scalar operations. [v7]

Jatin Bhateja jbhateja at openjdk.org
Tue Sep 19 16:16:12 UTC 2023


On Mon, 18 Sep 2023 22:18:44 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

> But this is actually a float16 here (short is only indicating the 16bit storage) and it is not expected to have any integral operation directly on this. The movswl would unnecessarily add to the pathlength.

We do have an API to return a raw value and a direct comparison b/w raw value is done at JVM word (32 bit) granularity, I was planning to remove additional sign extending move when we add Float16.compare(short, short), but I think its better to fix tests for now and remove this extra instruction.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/848#discussion_r1330384137



More information about the valhalla-dev mailing list