[lworld] RFR: 8328543: [lworld] Library and test updates to use --enable-preview instead of ValhallaFeatures [v6]
Mandy Chung
mchung at openjdk.org
Mon Apr 1 17:50:59 UTC 2024
On Thu, 28 Mar 2024 19:07:57 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 364:
>>
>>> 362: public Set<Location> apply(ClassFileFormatVersion cffv) {
>>> 363: return (cffv.compareTo(ClassFileFormatVersion.RELEASE_2) >= 0 &&
>>> 364: cffv.compareTo(ClassFileFormatVersion.RELEASE_16) <= 0) ?
>>
>> I believe we still want to keep the strict field modifier for value class fields.
>
> I dropped it because its not in JEP401 and the feature has not settled yet nor which spec its covered in.
I'm okay either way if you want to make change now or later. If the testing is good, it's fine to integrate this change and follow up later.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1060#discussion_r1546639387
More information about the valhalla-dev
mailing list