[lworld] RFR: 8331006: [lworld] Support of null markers for nullable flat fields [v2]

Frederic Parain fparain at openjdk.org
Mon Apr 29 15:38:25 UTC 2024


On Thu, 25 Apr 2024 11:20:05 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing issues spotted during reviews
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/NullableFlatFieldTest.java line 29:
> 
>> 27:  * @modules java.base/jdk.internal.vm.annotation
>> 28:  * @enablePreview
>> 29:  * @run main/othervm -XX:+EnableNullableFieldFlattening -XX:+PrintInlineLayout NullableFlatFieldTest
> 
> Although the tests are short (just now), shouldn't all uses of `EnableNullableFieldFlattening` need `-Xint` just now ?

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1078#discussion_r1583295136



More information about the valhalla-dev mailing list