[lworld+fp16] RFR: 8336406: Add support for FP16 binary operations [v2]

[Bhavana Kilambi]

On Thu, 8 Aug 2024 02:49:43 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add MulHF::Ideal() and MulHF Idealization tests
>
> Please address the closing comments and integrate.
> 
> Patch looks good to me. Will add x86 backend support for newly added intrinsic.

Hi @jatin-bhateja, I just noticed that the IR tests for x *2 -> x + x already exist for float and double here - `test/hotspot/jtreg/compiler/c2/irTests/TestMulNodeIdealization.java`. Shall I update this test with the Half float Ideal tests and remove this file introduced in this patch - `test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java`?
I am thinking, we will have to pass `--enable-preview` flag for the whole file which is applicable even for float and double tests which may not need it and we might not be able to test these testcases in older JDKs. What do you suggest? Is it better to keep this test separate for half-float or integrate it with float and double tests?

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1175#issuecomment-2276104821