[lworld+fp16] RFR: 8334432: Refine Float16.fma [v6]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Aug 9 19:35:43 UTC 2024


On Fri, 9 Aug 2024 18:56:44 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in test comments.
>
> test/jdk/java/lang/Float16/BasicFloat16ArithTests.java line 386:
> 
>> 384:          */
>> 385:         for(int i = 0; i <= Short.MAX_VALUE; i++ ) {
>> 386:             // Start by just checking positive values...
> 
> The test does, in fact, also check the negated value.
> It doesn't check negative zero, though.
> 
> Maybe it's simpler to loop like so
> 
>         for(int i = Short.MIN_VALUE; i <= Short.MAX_VALUE; i++ ) {
> 
> and drop the logic for the negated value.

Forget about this comment, except for the first line. The test is already complete

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1143#discussion_r1712045068


More information about the valhalla-dev mailing list