[lworld+fp16] RFR: 8334432: Refine Float16.fma [v7]

[Jatin Bhateja]

On Mon, 12 Aug 2024 05:57:17 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Adding comments and test cases for Float16.fma.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Respond to review feedback.

Hi @jddarcy ,
Thanks for very detailed educative comments. 
Looks good to me.

Best Regards,
Jatin

test/jdk/java/lang/Float16/BasicFloat16ArithTests.java line 422:

> 420:             checkFloat16(f16Neg, valueOf(-halfWayNextDown).floatValue(), roundDownMsg);
> 421: 
> 422:             // Should always round down up

Suggestion:

            // Should always round up

-------------

Marked as reviewed by jbhateja (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1143#pullrequestreview-2234029589
PR Review Comment: https://git.openjdk.org/valhalla/pull/1143#discussion_r1714374407