[lworld] Integrated: 8336778: [lworld] C2 compilation hits "invalid node class" assert when merging object field values

Tobias Hartmann thartmann at openjdk.org
Tue Aug 13 13:15:25 UTC 2024


On Tue, 13 Aug 2024 10:46:36 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> When preparing to merge field values, `InlineTypeNode::clone_with_phis` incorrectly looks at the field value instead of the field type to determine if Phis should be created. This leads to asserts or even incorrect execution, for example, in the case when the field type is Object, the field value in one branch is an InlineTypeNode but the field value in the other branch is not an InlineTypeNode. I added corresponding tests and also additional asserts that would catch the incorrect execution cases.
> 
> Best regards,
> Tobias

This pull request has now been integrated.

Changeset: e30fca0e
Author:    Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/valhalla/commit/e30fca0eca135955f1e33eddbed670ae5b6e232a
Stats:     100 lines in 3 files changed: 98 ins; 0 del; 2 mod

8336778: [lworld] C2 compilation hits "invalid node class" assert when merging object field values

-------------

PR: https://git.openjdk.org/valhalla/pull/1205


More information about the valhalla-dev mailing list