[lworld] Integrated: 8336782: [lworld] CallStaticJavaNode::remove_useless_allocation does not handle dying subgraph
Tobias Hartmann
thartmann at openjdk.org
Thu Aug 15 10:57:55 UTC 2024
On Thu, 15 Aug 2024 09:04:46 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> We assert when processing the `load_unknown_inline` call of a flat array load with unknown type because the call already has top as control input. This can happen when a subgraph is dying but depending on the IGVN worklist order, we visit one of the to-be-removed nodes before that. Unfortunately, I was not able to extract a simple test. The fix is to return when encountering a top input.
>
> I also fixed a few outdated comments and did some minor refactoring.
>
> Best regards,
> Tobias
This pull request has now been integrated.
Changeset: e19d6796
Author: Tobias Hartmann <thartmann at openjdk.org>
URL: https://git.openjdk.org/valhalla/commit/e19d67967dcd1a6e58b42109f7366968c206f739
Stats: 30 lines in 2 files changed: 2 ins; 4 del; 24 mod
8336782: [lworld] CallStaticJavaNode::remove_useless_allocation does not handle dying subgraph
-------------
PR: https://git.openjdk.org/valhalla/pull/1209
More information about the valhalla-dev
mailing list