[lworld+fp16] RFR: 8339252: Add method float16Value() to BigInteger and BigDecimal [v2]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Aug 30 16:30:32 UTC 2024


On Fri, 30 Aug 2024 13:01:09 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> This patch adds `float16Value()` to `BigInteger` and `BigDecimal`, as well as `Float16.valueOf(BigDecimal)`.
>
> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

I erroneously had this PR on the `lworld` branch, then moved it to the `lworld+fp16` branch, where it belongs.

However, the webrevs now show the diffs w.r.t. `lworld`, which is quite confusing.
In addition, the "Files changed" tab shows diffs for `Float16.valueOf(long)` that should not appear in `lworld+fp16`.

Short of closing this PR and open it again in the right branch (but I'm not sure this works without conflicts), I'm clueless.
So I'm asking for advice.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1228#issuecomment-2321872829


More information about the valhalla-dev mailing list