[lworld] RFR: 8345250: [lworld] C2: Array loads and stores on inexact flat arrays cause crashes [v2]

[Christian Hagedorn]

On Tue, 10 Dec 2024 12:35:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/share/opto/parseHelper.cpp line 265:
> 
>> 263:   // If we statically know that this is an inline type array, use precise element klass for checkcast
>> 264:   const TypeAryPtr* arytype = _gvn.type(ary)->is_aryptr();
>> 265:   const TypePtr* elem_ptr = elemtype->make_ptr();
> 
> Should this be moved to the else branch?

Good point, I think I've missed to update the usages below. Pushed an update accordingly.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1314#discussion_r1880173115