[lworld] RFR: 8346035: [lworld] javadoc for value objects when enable preview [v2]

Roger Riggs rriggs at openjdk.org
Thu Dec 12 20:42:37 UTC 2024


On Wed, 11 Dec 2024 22:19:20 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tidy up ValueBased.html
>
> src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 70:
> 
>> 68:     {@link java.lang.IdentityException} is thrown.</p>
>> 69: 
>> 70: <p>When preview features are enabled, use of value class instances for synchronization, mutexes, or with
> 
> Should we include the 
> 
> <div class="preview-block">
>      <div class="preview-comment">
> 
> blocks here?

In this context the preview-block looks out of place.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1316#discussion_r1882854141


More information about the valhalla-dev mailing list