[lworld] RFR: 8346035: [lworld] javadoc for value objects when enable preview [v2]

[Dan Smith]

On Fri, 13 Dec 2024 20:41:11 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Tidy up ValueBased.html
>
> src/java.base/share/classes/java/lang/doc-files/ValueBased.html line 48:
> 
>> 46:         visible change in the behavior of the class's methods;</li>
>> 47:     <li>the class performs no synchronization using an instance's monitor;</li>
>> 48:     <li>the class does not declare (or has deprecated any) accessible constructors;</li>
> 
> This one is still relevant, as a concrete case of the next bullet, right? A value-based class should not let clients control identity creation.

Could maybe soften to "(or discourages use of any)"...

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1316#discussion_r1884530682