RFR: 8324873: [lworld] implementation of value classes construction [v3]

Chen Liang liach at openjdk.org
Fri Feb 9 16:25:09 UTC 2024


On Fri, 9 Feb 2024 15:44:27 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> implementing value classes construction approach as per JEP-401. There is also a bit of an off-road incursion into jdeps removing references to Q-descriptors, probably should have gone in another patch but the changes are kind of small anyways
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   addressing review comments, adding more regression tests

src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 371:

> 369:                    } else {
> 370:                        return (cffv.compareTo(ClassFileFormatVersion.RELEASE_2) >= 0 &&
> 371:                                cffv.compareTo(ClassFileFormatVersion.RELEASE_16) <= 0) ?

We can probably change this ternary operator to be part of the if-else chain to make it clearer.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/990#discussion_r1484540887



More information about the valhalla-dev mailing list