[lworld] RFR: JDK-8325344: [lworld] RedefinePrimitive.java fails javac compilation

Alex Menkov amenkov at openjdk.org
Fri Feb 9 21:47:07 UTC 2024


On Thu, 8 Feb 2024 22:43:24 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> This change is fine in fixing the compilation error.
> 
> We are migrating tests that use primitive value class to use the internal APIs (you can reference #991). Can you repurpose this issue to update the test? The test should be renamed too like `RedefineNullRestrictedValues.java` something like that.

Thank you for the comment.
Tried to update the test to use internal API and realized that testing for NullRestricted value classes are completely different.
Also this test does not actually works with the current code (even for primitive classes).
I think it would be better to drop this test and develop test scenarios for NullRestricted value classes (will create a separate CR for this)

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1001#issuecomment-1936645224



More information about the valhalla-dev mailing list