[lworld] RFR: 8326707: [lworld] Remove VALUE modifier from Modifier and AccessFlag [v3]

Mandy Chung mchung at openjdk.org
Wed Feb 28 18:29:54 UTC 2024


On Wed, 28 Feb 2024 18:20:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Remove the VALUE modifier in Modifier.java and AccessFlag.java.
>> Update Class.isValue() to be false for primitive, array, and interface classes and otherwise be ~ACC_IDENTITY in the modifiers.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Tweek to use || consistent with other uses in Class

Marked as reviewed by mchung (Committer).

test/jdk/java/lang/reflect/AccessFlag/ClassAccessFlagTest.java line 62:

> 60:                 StaticTestInterface.class,
> 61:                 TestMarkerAnnotation.class,
> 62:                 ExpectedClassFlags.class,

nit: extra 4-space indentation.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1024#pullrequestreview-1906972879
PR Review Comment: https://git.openjdk.org/valhalla/pull/1024#discussion_r1506398200



More information about the valhalla-dev mailing list