[lworld+fp16] RFR: 8333852: Allow flat array layout for value based classes.

[Bhavana Kilambi]

On Wed, 3 Jul 2024 14:58:03 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorSum.java line 46:
>> 
>>> 44: 
>>> 45:     public static void main(String args[]) {
>>> 46:         TestFramework.runWithFlags("--enable-preview", "-XX:-TieredCompilation", "-Xbatch");
>> 
>> Hi Jatin, thanks for this patch. May I ask, why `-XX:-TieredCompilation` option is passed? It's one of the whitelisted flags and must be already applied when compiling the test isn't it?
>
> Does this test works for you ?
> I faced some failure with this test despite of passing --enable-preview, this works in the standalone (non-jtreg) mode though.  Somehow --enable-preview option is not being passed while loading one of the test harness class (OutputBuffer) which has preview specific minor version. This could be gap in IR framework, but I need to confirm it.
> 
> On your query, white listing filters out passing any non-whitelisted option to IR framework.

Yes, I also get the same error as you. Somehow the test passes when the `@enablePreview` flag is removed from line #28. I am not sure why though. I can see FP16 vectorized code on aarch64 as well. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1154#discussion_r1664430219