[lworld+fp16] RFR: 8334432: Refine Float16.fma
Jatin Bhateja
jbhateja at openjdk.org
Fri Jul 5 12:36:26 UTC 2024
On Fri, 5 Jul 2024 12:02:31 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Adding comments and test cases for Float16.fma.
>
> test/jdk/java/lang/Float16/BasicFloat16ArithTests.java line 555:
>
>> 553:
>> 554: {0x1.0p-24f, 0x1.0p-24f, 0x1.0p14f,
>> 555: 0x1.0p14f},
>
> Your tests only covers overflow conditions, a few going below minimum sub-normal value (0x0.004P-14) will be useful.
My query was in following context, citing excerpt from JVM Specification 22 section 2.11.3.
"The Java Virtual Machine does not indicate overflow or underflow during
operations on floating-point data types. That is, floating-point instructions never
cause the Java Virtual Machine to throw a run-time exception (not to be confused
with an IEEE 754 floating-point exception). **An operation that overflows produces
a signed infinity; an operation that underflows produces a subnormal value or a
signed zero;** an operation that has no unique mathematically defined result produces
NaN. All numeric operations with NaN as an operand produce NaN as a result"
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1143#discussion_r1666754196
More information about the valhalla-dev
mailing list