[lworld+fp16] RFR: 8330021: AArch64: Add backend support for FP16 add operation [v4]
Jatin Bhateja
jbhateja at openjdk.org
Fri Jul 5 13:50:28 UTC 2024
On Fri, 5 Jul 2024 13:33:32 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:
>> Current rules looks ok to me, I just wrongly interpreted the results on x86 where one of the two IR rules failed, and that is bound to happene since these features are AARCH64 specific.
>
> By "IR rules failed" you mean IR rule was not applied due to "feature constraints not met" right (for the second IR rule)? Hope the test did not fail. It should not ideally.
Some rules were not enforced and showed up in debug log, Test passed 👍
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1096#discussion_r1666831219
More information about the valhalla-dev
mailing list