[lworld] RFR: 8310655: [lworld] ShouldNotReachHere() error in ObjectSynchronizer::FastHashCode [v2]

[Frederic Parain]

On Tue, 9 Jul 2024 16:11:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change uses the klass as the hashcode for inline objects.  It might have some negative performance impact if there are a lot of objects of the same type in the heap walk but it's better than crashing.
>> Tested with vmTestbase/nsk/jvmti tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve comment.

Looks good to prevent the crash.
As put in the comment, we'll need more data in the future to know if it creates a performance issue.

-------------

Marked as reviewed by fparain (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1156#pullrequestreview-2167132216