[lworld] RFR: 8335545: [lworld] JNI MonitorEnter doesn't throw the right exception [v2]

Coleen Phillimore coleenp at openjdk.org
Tue Jul 9 21:22:37 UTC 2024


On Tue, 9 Jul 2024 21:07:37 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Fix JNI's MonitorEnter to throw IdentityException instead of IllegalMonitorStateException.
>
> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changes suggested by Coleen

This looks good.  One small line change.

src/hotspot/share/runtime/synchronizer.cpp line 564:

> 562: void ObjectSynchronizer::enter(Handle obj, BasicLock* lock, JavaThread* current) {
> 563:   assert(current == Thread::current(), "must be");
> 564:   JavaThread* THREAD = current;

You don't need the THREAD line anymore.

-------------

Marked as reviewed by coleenp (no project role).

PR Review: https://git.openjdk.org/valhalla/pull/1160#pullrequestreview-2167519366
PR Review Comment: https://git.openjdk.org/valhalla/pull/1160#discussion_r1671252280


More information about the valhalla-dev mailing list