[lworld+fp16] RFR: 8330021: AArch64: Add backend support for FP16 add operation [v5]

Bhavana Kilambi bkilambi at openjdk.org
Wed Jul 10 20:27:45 UTC 2024


On Wed, 10 Jul 2024 10:21:25 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> test/hotspot/jtreg/compiler/vectorization/TestFP16VectorReinterpretConv.java line 1:
> 
>> 1: /*
> 
> We have another test in the same directory with TestFloat16* nomenclature, I think we should pick one naming scheme.

I thought so too but was just trying to use a test name as small as possible as it was already geting bigger. But I don't mind replacing it with *Float16*. Will do that. thanks

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1096#discussion_r1672030822


More information about the valhalla-dev mailing list