[lworld] RFR: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes

[Frederic Parain]

On Fri, 19 Jul 2024 12:12:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> The test uses the class file reconstituter to provide the redefined bytecodes, leaving out the LoadableDescriptors.  Adding them to the reconsistituted class file makes the test pass, also fix the verification code since these descriptors are utf8s now.  Tested with java/lang/instrument with --enable-preview.  Should write a test but I don't know how, and the code is already tested with permitted subclasses and other attributes.

Hi Coleen,

Thank you for the fix in ClassFileReconstituter, the handling of the LoadableDescriptors attribute was clearly missing.
However, I'm wondering if class redefinition should reject redefined classes with a missing or different LoadableDescriptors attribute. This attribute helps the VM optimizing this class, but it is not supposed to impact the semantic of the class.

Fred

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1172#issuecomment-2239300930