[lworld] RFR: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes

[Coleen Phillimore]

On Fri, 19 Jul 2024 12:12:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> The test uses the class file reconstituter to provide the redefined bytecodes, leaving out the LoadableDescriptors.  Adding them to the reconsistituted class file makes the test pass, also fix the verification code since these descriptors are utf8s now.  Tested with java/lang/instrument with --enable-preview.  Should write a test but I don't know how, and the code is already tested with permitted subclasses and other attributes.

That's a good question.  Maybe this attribute shouldn't be matched in the redefined class.  Although potentially different LoadableDescriptors might change the behavior of the redefined class by preloading a different class?  And maybe we don't want that.  So maybe missing is okay, but different is bad?

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1172#issuecomment-2239407247