[lworld] RFR: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes [v3]
Coleen Phillimore
coleenp at openjdk.org
Fri Jul 19 16:48:54 UTC 2024
> The test uses the class file reconstituter to provide the redefined bytecodes, leaving out the LoadableDescriptors. Adding them to the reconsistituted class file makes the test pass, also fix the verification code since these descriptors are utf8s now. Tested with java/lang/instrument with --enable-preview. Should write a test but I don't know how, and the code is already tested with permitted subclasses and other attributes.
Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
Add back the oxford comma.
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1172/files
- new: https://git.openjdk.org/valhalla/pull/1172/files/7343a17d..7665d5b3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1172&range=02
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1172&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/valhalla/pull/1172.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1172/head:pull/1172
PR: https://git.openjdk.org/valhalla/pull/1172
More information about the valhalla-dev
mailing list