[lworld+fp16] RFR: 8336406: Add support for FP16 binary operations
Jatin Bhateja
jbhateja at openjdk.org
Wed Jul 31 10:53:45 UTC 2024
On Tue, 30 Jul 2024 13:45:47 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:
>> This patch adds middle end support in C2 for a few FP16 binary operations, namely - subtract, multiply, divide, min and max. It also adds aarch64 backend support for these operations.
>>
>> Tested JTREG tests -
>> hotspot/jtreg/compiler/vectorization/TestFloat16VectorOps.java, hotspot/jtreg/compiler/vectorization/TestFloat16VectorReinterpretConv.java, hotspot/jtreg/compiler/intrinsics/float16 and test/jdk/java/lang/Float16 and they successfully pass on aarch64 and x86 machines.
>
> Hi @jatin-bhateja , can I please get some review for this patch? Thank you !
Hi @Bhavana-Kilambi ,
Your patch looks good to me, just one comment.
Once it gets integrated I will add x86 backend support for newly supported intrinsic.
Best Regards,
Jatin
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1175#issuecomment-2260232815
More information about the valhalla-dev
mailing list