[lworld+fp16] RFR: 8329817: Augment prototype Float16 class

Joe Darcy darcy at openjdk.org
Tue Jun 11 19:46:31 UTC 2024


On Fri, 7 Jun 2024 04:22:49 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Sketch of a more full-featured API for Float16.
>
> This PR has some known to-do items, including testing, but the PR does provide a more full featured API set on par with Float or Double, although without all the float/double handling method in Math/StrictMath.
> 
> One to-do item is writing the double -> float16 conversion routine. Other items include adjusting the binary <-> decimal conversion process to deal with the reduced precision of float16.

> Hi @jddarcy ,
> 
> There are few more tests which may need refinement jtreg:test/hotspot/jtreg/compiler/intrinsics/float16/TestFP16ScalarAdd.java jtreg:test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorSum.java
> 
> Best Regards, Jatin

Okay; I updated both tests to reflect the changes in the Float16 API. While TestFloat16VectorSum.java run successfully, TestFP16ScalarAdd fails at runtime with a message equivalent to "preview not enabled." Given the source of the test, I'm not sure what preview isn't being enabled as needed.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1117#issuecomment-2161487279



More information about the valhalla-dev mailing list