[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v5]

[Joe Darcy]

On Wed, 12 Jun 2024 20:43:00 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Hi @jddarcy , Apart from few minor comments, patch looks good to me, there is a build error due to malformed javadoc comment.
> 
> Kindly fix and integrate.

Thanks; let me take a pass at writing at least some basic regression tests before pushing.

@jatin-bhateja , do you know if promoting the three operands of a Float16 fma to double, doing the operation in double, and rounding to Float16 is sufficient to correctly implement a Float16 fma? I haven't worked through all the cases yet and I'm not certain they're cannot be double-rounding issues. (If double rounding turns out to be a problem, I was thinking it would be possible to see if (a*b + c) was exact in double, and if, not add in a sticky bit to make sure the rounding occurs properly, but I haven't developed the details yet.)

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1117#issuecomment-2164012295